Code Review

This pull request introduces a memoize attribute to the node macro, enabling automatic caching for specific nodes. The changes include updating the NodeMetadata struct, enhancing the macro's parsing and code generation to handle the new attribute, and modifying the preprocessor to insert a Memo node into the subnetwork when memoization is enabled. Additionally, the sample_polyline node has been updated to utilize this feature. I have no feedback to provide.

1 issue found across 6 files

Confidence score: 3/5

• There is a concrete medium-severity risk in node-graph/preprocessor/src/lib.rs: when generated_nodes == 0, the memoize flag is ignored, so expected Memo nodes are not appended.
• Because this affects memoized nodes without conversion wrappers, behavior can regress in real graph execution paths, which makes this more than a minor housekeeping issue.
• Given the high confidence (9/10) and clear functional impact, this looks like some merge risk rather than a merge blocker.
• Pay close attention to node-graph/preprocessor/src/lib.rs - ensure Memo node insertion still occurs for memoized nodes even when no conversion nodes are generated.

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/preprocessor/src/lib.rs">

<violation number="1" location="node-graph/preprocessor/src/lib.rs:131">
P2: `memoize` is ignored when `generated_nodes == 0`, so memoized nodes without conversion wrappers never get the Memo node appended.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}